[GitHub] [geode] DonalEvans commented on a change in pull request #6831: GEODE-9519: Implement Radish ZSCAN command

[GitBox <gi...@apache.org>]

DonalEvans commented on a change in pull request #6831:
URL: https://github.com/apache/geode/pull/6831#discussion_r701388381



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/key/ScanExecutor.java
##########
@@ -103,7 +104,7 @@ public RedisResponse executeCommand(Command command, ExecutionHandlerContext con
         scan(getDataRegion(context).keySet(), matchPattern, count, cursor);
     context.setScanCursor(scanResult.getLeft());
 
-    return RedisResponse.scan(scanResult.getLeft(), scanResult.getRight());
+    return RedisResponse.scan(scanResult.getLeft().intValue(), scanResult.getRight());
   }
 
   private Pair<BigInteger, List<Object>> scan(Collection<RedisKey> list,

Review comment:
       I didn't want to have this PR get too big, so I haven't changed the existing implementations for SCAN or SSCAN. They're currently not supported commands, so I've left that work for whoever eventually implements them in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org