You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/05 16:35:41 UTC

[GitHub] [incubator-doris] cambyzju opened a new pull request, #8822: [fix] min and max window function bug fix

cambyzju opened a new pull request, #8822:
URL: https://github.com/apache/incubator-doris/pull/8822

   # Proposed changes
   
   Issue Number: close #8814
   
   ## Problem Summary:
   1. min bug:
   As we know, to calc min value, we set the intermediate value to MAX_VALUE, then compare and update it with each cell.
   But in function AggFnEvaluator::update_or_merge, we reset the intermediate value by an default value(0). It is not correct.
   
   2. max bug:
   It is the same as min.
   
   3. remove unused codes: AggFnEvaluator::merge
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   4. Has document been added or modified: (Yes/No/No Need)
   5. Does it need to update dependencies: (Yes/No)
   6. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8822: [fix] min and max window function bug fix

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8822:
URL: https://github.com/apache/incubator-doris/pull/8822#issuecomment-1089772376

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8822: [fix] min and max window function bug fix

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8822:
URL: https://github.com/apache/incubator-doris/pull/8822#issuecomment-1089772330

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei merged pull request #8822: [fix] min and max window function bug fix

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #8822:
URL: https://github.com/apache/incubator-doris/pull/8822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org