You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2025/11/13 14:15:33 UTC
[Impala-ASF-CR] IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23669
Change subject: IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
......................................................................
IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
This patch updates CDP_BUILD_NUMBER to 71942734 to in order to
upgrade Iceberg to 1.5.2.
This patch updates some tests so they pass with Iceberg 1.5.2. The
behavior changes of Iceberg 1.5.2 are (compared to 1.3.1):
* Iceberg V2 tables are created by default
* Metadata tables have different schema
* Parquet compression is explicitly set for new tables (even for ORC
tables)
* Sequence numbers are assigned a bit differently
Updated the tests where needed.
Code changes to accomodate for the above behavior changes:
* SHOW CREATE TABLE adds 'format-version'='1' for Iceberg V1 tables
* CREATE TABLE statements don't throw errors when Parquet compression
is set for ORC tables
Change-Id: Ibba1459b3c447269f012ecf306bcbc7cb9c0763f
---
M bin/impala-config.sh
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter-default.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-virtual-columns.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table-with-stats.test
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
10 files changed, 112 insertions(+), 173 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/23669/1
--
To view, visit http://gerrit.cloudera.org:8080/23669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibba1459b3c447269f012ecf306bcbc7cb9c0763f
Gerrit-Change-Number: 23669
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/23669 )
Change subject: IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
......................................................................
Abandoned
Abandoned for https://gerrit.cloudera.org/#/c/23670/ to have a new Change-Id.
--
To view, visit http://gerrit.cloudera.org:8080/23669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibba1459b3c447269f012ecf306bcbc7cb9c0763f
Gerrit-Change-Number: 23669
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23669 )
Change subject: IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20895/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibba1459b3c447269f012ecf306bcbc7cb9c0763f
Gerrit-Change-Number: 23669
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 14:41:52 +0000
Gerrit-HasComments: No