You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "SbloodyS (via GitHub)" <gi...@apache.org> on 2024/11/15 06:26:05 UTC
[PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
SbloodyS opened a new pull request, #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
close #16801
## Brief change log

## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2480528560
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [57.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#discussion_r1845995565
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitor.java:
##########
@@ -123,9 +124,15 @@ private static ResourceComponent getResourceComponent(StorageEntity resource) {
tempResourceComponent = new FileLeaf();
}
+ String currentDir = "";
+ if (resource.getFullName().contains(Constants.RESOURCE_TYPE_FILE)) {
+ currentDir = resource.getFullName().split(Constants.RESOURCE_TYPE_FILE)[1].substring(1);
+ }
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#discussion_r1845969604
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/StorageOperator.java:
##########
@@ -24,9 +24,6 @@
public interface StorageOperator {
- String FILE_FOLDER_NAME = "resources";
- String UDF_FOLDER_NAME = "udfs";
Review Comment:
The `udfs` have been remove from `ResourceType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2482196575
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [25.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2478157094
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [57.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#discussion_r1845948753
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/StorageOperator.java:
##########
@@ -24,9 +24,6 @@
public interface StorageOperator {
- String FILE_FOLDER_NAME = "resources";
- String UDF_FOLDER_NAME = "udfs";
Review Comment:
Please Keep these two fields, we should avoid add all constants in Constants, these fields in StorageOperator is also static. You can get these by `StorageOperator.FILE_FOLDER_NAME`
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitor.java:
##########
@@ -123,9 +124,15 @@ private static ResourceComponent getResourceComponent(StorageEntity resource) {
tempResourceComponent = new FileLeaf();
}
+ String currentDir = "";
+ if (resource.getFullName().contains(Constants.RESOURCE_TYPE_FILE)) {
+ currentDir = resource.getFullName().split(Constants.RESOURCE_TYPE_FILE)[1].substring(1);
+ }
Review Comment:
This is not safe, we should parse the `ResourceMetaData` and check whether the `resource'resourceType` is `FILE`. You can find some code under `AbstractStorageOperator#getResourceMetaData`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2481806709
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [57.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2481807284
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [57.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2478155978
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [57.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2480528593
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [57.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16801][UI] Add copy path of resource file in task definition [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16803:
URL: https://github.com/apache/dolphinscheduler/pull/16803#issuecomment-2482197910
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803) **Quality Gate failed**
Failed conditions
 [25.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16803&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16803)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org