You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/08/23 01:36:09 UTC

[kudu-CR] dense node-itest: add extra log output 

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7775

to review the following change.

Change subject: dense_node-itest: add extra log output
......................................................................

dense_node-itest: add extra log output

For yet-unexplained reasons, this itest still sometimes skips outputting
the expected 'Time spent bootstrapping tablets' log statement. This
commit simply adds a few extra log messages to help diagnose this next
time it occurs.

Change-Id: Ic967558e34a8db673a518c37afdb68d86262a443
---
M src/kudu/integration-tests/dense_node-itest.cc
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/7775/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic967558e34a8db673a518c37afdb68d86262a443
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] dense node-itest: add extra log output

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: dense_node-itest: add extra log output
......................................................................


Patch Set 1: Code-Review+2

Sure, why not.

-- 
To view, visit http://gerrit.cloudera.org:8080/7775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic967558e34a8db673a518c37afdb68d86262a443
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] dense node-itest: add extra log output

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: dense_node-itest: add extra log output
......................................................................


dense_node-itest: add extra log output

For yet-unexplained reasons, this itest still sometimes skips outputting
the expected 'Time spent bootstrapping tablets' log statement. This
commit simply adds a few extra log messages to help diagnose this next
time it occurs.

Change-Id: Ic967558e34a8db673a518c37afdb68d86262a443
Reviewed-on: http://gerrit.cloudera.org:8080/7775
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/dense_node-itest.cc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic967558e34a8db673a518c37afdb68d86262a443
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>