You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/03 02:11:20 UTC

[GitHub] [beam] reuvenlax commented on a change in pull request #15810: [BEAM-2791] Support low-latency StorageApi sink with no exactly-once guarantees

reuvenlax commented on a change in pull request #15810:
URL: https://github.com/apache/beam/pull/15810#discussion_r741575360



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java
##########
@@ -85,6 +85,13 @@
 
   void setUseStorageWriteApi(Boolean value);
 
+  @Description(
+      "If set, then BigQueryIO.Write will default to using the approximate Storage Write API.")

Review comment:
       second half looks good. First half isn't quite right, since it will only default (i.e. it's the default if withMethod isn't called, otherwise this is ignored).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org