You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/11/02 09:34:04 UTC
[GitHub] [incubator-hugegraph-toolchain] z7658329 opened a new pull request, #353: change package to org.apache.hugegraph
z7658329 opened a new pull request, #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353
change package to org.apache.hugegraph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #353: change package to org.apache.hugegraph
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1305616058
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#353](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2fe651) into [adapt-common](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/6374d5f0b53d9577b1dc826c81dc90636ecb0807?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6374d5f) will **increase** coverage by `77.85%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## adapt-common #353 +/- ##
===================================================
+ Coverage 0.00% 77.85% +77.85%
- Complexity 0 972 +972
===================================================
Files 86 156 +70
Lines 4031 4082 +51
Branches 478 242 -236
===================================================
+ Hits 0 3178 +3178
+ Misses 4031 725 -3306
- Partials 0 179 +179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ent/src/main/java/com/baidu/hugegraph/api/API.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL0FQSS5qYXZh) | `87.50% <ø> (ø)` | |
| [...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvQWNjZXNzQVBJLmphdmE=) | `100.00% <ø> (ø)` | |
| [...n/java/com/baidu/hugegraph/api/auth/BelongAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvQmVsb25nQVBJLmphdmE=) | `100.00% <ø> (ø)` | |
| [...in/java/com/baidu/hugegraph/api/auth/GroupAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvR3JvdXBBUEkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...in/java/com/baidu/hugegraph/api/auth/LoginAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvTG9naW5BUEkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../java/com/baidu/hugegraph/api/auth/ProjectAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvUHJvamVjdEFQSS5qYXZh) | `100.00% <ø> (ø)` | |
| [...n/java/com/baidu/hugegraph/api/auth/TargetAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvVGFyZ2V0QVBJLmphdmE=) | `100.00% <ø> (ø)` | |
| [...in/java/com/baidu/hugegraph/api/auth/TokenAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvVG9rZW5BUEkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvVXNlckFQSS5qYXZh) | `100.00% <ø> (ø)` | |
| [...in/java/com/baidu/hugegraph/api/graph/EdgeAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2dyYXBoL0VkZ2VBUEkuamF2YQ==) | `93.87% <ø> (ø)` | |
| ... and [319 more](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/353/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #353: refact: adopt & use apache version in toolchain
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#discussion_r1015555925
##########
hugegraph-tools/pom.xml:
##########
@@ -38,7 +38,7 @@
<shell-executable>bash</shell-executable>
<junit.version>4.12</junit.version>
<maven.build.timestamp.format>yyyy-MM-dd HH:mm:ssZ</maven.build.timestamp.format>
- <hugegraph-client-version>2.0.1</hugegraph-client-version>
+ <hugegraph-client-version>1.0.0</hugegraph-client-version>
Review Comment:
oh, no need use a param now (just use inner version param is enough)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #353: refact: adopt & use apache version in toolchain
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#discussion_r1015529838
##########
hugegraph-tools/pom.xml:
##########
@@ -38,7 +38,7 @@
<shell-executable>bash</shell-executable>
<junit.version>4.12</junit.version>
<maven.build.timestamp.format>yyyy-MM-dd HH:mm:ssZ</maven.build.timestamp.format>
- <hugegraph-client-version>2.0.1</hugegraph-client-version>
+ <hugegraph-client-version>1.0.0</hugegraph-client-version>
Review Comment:
seems we need use ${revision} here? (or enhance it in next PR)
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/api/schema/PropertyKeyAPI.java:
##########
@@ -25,12 +25,12 @@
import com.baidu.hugegraph.api.task.TaskAPI;
import com.baidu.hugegraph.client.RestClient;
import com.baidu.hugegraph.exception.NotSupportException;
-import com.baidu.hugegraph.rest.RestResult;
+import org.apache.hugegraph.rest.RestResult;
import com.baidu.hugegraph.structure.SchemaElement;
import com.baidu.hugegraph.structure.constant.HugeType;
import com.baidu.hugegraph.structure.constant.WriteType;
import com.baidu.hugegraph.structure.schema.PropertyKey;
-import com.baidu.hugegraph.util.E;
+import org.apache.hugegraph.util.E;
Review Comment:
TODO: the import style is not right now, could enhance it in next PR (or unify it when all repo rename)
so as the other file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #353: change depnd to org.apache.hugegraph
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1305674300
<img width="930" alt="image" src="https://user-images.githubusercontent.com/5474723/200330977-04ac0336-221f-474d-a739-aa50254a654c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #353: refact: adopt & use apache version in toolchain
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1307063263
why hubble failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin merged pull request #353: refact: adopt & use apache version in toolchain
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on a diff in pull request #353: refact: adopt & use apache version in toolchain
Posted by GitBox <gi...@apache.org>.
z7658329 commented on code in PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#discussion_r1015548479
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/api/schema/PropertyKeyAPI.java:
##########
@@ -25,12 +25,12 @@
import com.baidu.hugegraph.api.task.TaskAPI;
import com.baidu.hugegraph.client.RestClient;
import com.baidu.hugegraph.exception.NotSupportException;
-import com.baidu.hugegraph.rest.RestResult;
+import org.apache.hugegraph.rest.RestResult;
import com.baidu.hugegraph.structure.SchemaElement;
import com.baidu.hugegraph.structure.constant.HugeType;
import com.baidu.hugegraph.structure.constant.WriteType;
import com.baidu.hugegraph.structure.schema.PropertyKey;
-import com.baidu.hugegraph.util.E;
+import org.apache.hugegraph.util.E;
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #353: change depnd to org.apache.hugegraph
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1305731639
and try rerun it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #353: refact: adopt & use apache version in toolchain
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1307279978
> why hubble failed?
>
> 
test code compile error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #353: change depnd to org.apache.hugegraph
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1305703015
i have reopen some ignored ut, do you know this error before?
<img width="1024" alt="image" src="https://user-images.githubusercontent.com/5474723/200335637-c4b525fc-1f33-4443-a5d1-f7792375cdf1.png">
<img width="1024" alt="image" src="https://user-images.githubusercontent.com/5474723/200335422-f89eb61d-0f97-4f69-a4ec-8f1d6eb0e9d5.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on pull request #353: change package to org.apache.hugegraph
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #353:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/353#issuecomment-1303830422
ci error:
`Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find artifact org.apache.hugegraph:hugegraph-common:jar:1.0.0 in central (https://repo.maven.apache.org/maven2)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org