You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/23 06:20:10 UTC
[GitHub] [iceberg] kbendick edited a comment on pull request #4202: CORE - Add main error handlers for use with REST catalog's HTTP client
kbendick edited a comment on pull request #4202:
URL: https://github.com/apache/iceberg/pull/4202#issuecomment-1048450953
Updated some of the exceptions that are annotated with `@FormatMessage` to include a constructor with just `String message` to pass checkstyle.
I figure this is ok, as we already allow for a format string with arguments (and no throwable). It's either this, or use a format string of `"%s"` and then pass `error.message()` to it. Seems kind of silly to do that, but if we don't want to expose a constructor with a signature of `String` only for the exceptions, we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org