You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/12/04 19:38:43 UTC

[GitHub] [maven] MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

MartinKanters commented on a change in pull request #287: [MNG-6065] - Log fail-level option.
URL: https://github.com/apache/maven/pull/287#discussion_r353943093
 
 

 ##########
 File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 ##########
 @@ -541,6 +543,18 @@ else if ( cliRequest.commandLine.hasOption( CLIManager.BATCH_MODE )
 
         plexusLoggerManager = new Slf4jLoggerManager();
         slf4jLogger = slf4jLoggerFactory.getLogger( this.getClass().getName() );
+
+        if ( cliRequest.commandLine.hasOption( CLIManager.FAIL_LEVEL ) )
+        {
+            String logLevelThreshold = cliRequest.commandLine.getOptionValue( CLIManager.FAIL_LEVEL );
+
+            if ( slf4jLoggerFactory instanceof MavenSlf4jWrapperFactory )
 
 Review comment:
   Good points, will add some logging on both if-statements!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services