You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/01/14 01:22:28 UTC
[GitHub] [servicecomb-service-center] little-cui commented on a change in
pull request #622: [SCB-1719] Support access log
little-cui commented on a change in pull request #622: [SCB-1719] Support access log
URL: https://github.com/apache/servicecomb-service-center/pull/622#discussion_r366111391
##########
File path: server/core/config.go
##########
@@ -108,12 +108,14 @@ func newInfo() pb.ServerInformation {
CompactIndexDelta: beego.AppConfig.DefaultInt64("compact_index_delta", 100),
CompactInterval: beego.AppConfig.String("compact_interval"),
- LogRotateSize: maxLogFileSize,
- LogBackupCount: maxLogBackupCount,
- LogFilePath: beego.AppConfig.String("logfile"),
- LogLevel: beego.AppConfig.String("loglevel"),
- LogFormat: beego.AppConfig.DefaultString("log_format", "text"),
- LogSys: beego.AppConfig.DefaultBool("log_sys", false),
+ LogRotateSize: maxLogFileSize,
+ LogBackupCount: maxLogBackupCount,
+ LogFilePath: beego.AppConfig.String("logfile"),
+ LogLevel: beego.AppConfig.String("loglevel"),
+ LogFormat: beego.AppConfig.DefaultString("log_format", "text"),
+ LogSys: beego.AppConfig.DefaultBool("log_sys", false),
+ EnableAccessLog: beego.AppConfig.String("enable_access_log") == "true",
Review comment:
配置没有这个选项，就没必要定义了，可以在实现里面判断
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services