[jira] [Commented] (AURORA-506) Tasks need to be sanitized before attempting a diff operation

["Mark Chu-Carroll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025173#comment-14025173 ] 

Mark Chu-Carroll commented on AURORA-506:
-----------------------------------------

I'm working on addressing this, and also some user complaints about how diffs work at the same time.

I'm setting up a diff routine that doesn't use the shell diff at all. Instead, it iterates over the fields in a JSON structure, looking for differences. The comparison takes a parameter which specifies a list of fields that should not be considered during the comparison.


> Tasks need to be sanitized before attempting a diff operation
> -------------------------------------------------------------
>
>                 Key: AURORA-506
>                 URL: https://issues.apache.org/jira/browse/AURORA-506
>             Project: Aurora
>          Issue Type: Story
>          Components: Client
>            Reporter: Maxim Khutornenko
>            Assignee: Mark Chu-Carroll
>
> Irrelevant thrift TaskConfig fields should not produce a diff noise resulting in unnecessary instance updates. Couple of observed cases:
> - TaskConfig field renaming triggers an instance update when scheduler and client are on different thrift schemas during the version upgrade period;
> - Identity.user field diff prevents a suspended job update to be resumed by a different user as the update restarts from scratch.
> To better protect against the problems above, the client api needs to have something like DiffSanitizer where both local and remote tasks would be brought to a common denominator before attempting a diff. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)