[GitHub] [superset] michael-s-molina commented on a diff in pull request #21952: fix(explore): Small changes in metadata bar copy and tooltip placement

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #21952:
URL: https://github.com/apache/superset/pull/21952#discussion_r1006931833


##########
superset-frontend/src/components/MetadataBar/MetadataBar.tsx:
##########
@@ -149,7 +149,10 @@ const Item = ({
     </StyledItem>
   );
   return isTruncated || collapsed || (tooltip && tooltip !== title) ? (
-    <Tooltip title={<TootipContent>{tooltip}</TootipContent>}>
+    <Tooltip
+      placement="bottom"

Review Comment:
   @kgabryje I'm not sure if we should set this in the component itself. The original behavior follows the one defined in Ant Design that automatically repositions the tooltip depending on the available space and tooltip content. We may have cases where the user scrolls down and the tooltip will need to be displayed on top. If you want to ensure that in Explore the tooltip is always displayed at the bottom, then I suggest adding a property to the `MetadataBar` called `tooltipPlacement` and pass it to the Tooltip component.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org