[jira] [Commented] (KYLIN-3292) The setting config dialog will cause NPE in Kylin server

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410690#comment-16410690 ] 

ASF GitHub Bot commented on KYLIN-3292:
---------------------------------------

chenzhx closed pull request #116: KYLIN-3292
URL: https://github.com/apache/kylin/pull/116
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/partials/admin/admin.html b/webapp/app/partials/admin/admin.html
index b57ce0eb0e..5c66942a7e 100644
--- a/webapp/app/partials/admin/admin.html
+++ b/webapp/app/partials/admin/admin.html
@@ -123,7 +123,7 @@ <h4>Update Config</h4>
       </div>
     </div>
     <div class="modal-footer">
-      <button class="btn btn-primary" ng-click="update()">Update</button>
+      <button class="btn btn-primary" ng-click="update()" ng-disabled="config_update_form.key_input.$invalid || config_update_form.value_input.$invalid">Update</button>
       <button class="btn btn-primary" ng-click="cancel()">Cancel</button>
     </div>
   </ng-form>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The setting config dialog will cause NPE in Kylin server
> --------------------------------------------------------
>
>                 Key: KYLIN-3292
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3292
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.4.0
>            Reporter: Peng Xing
>            Assignee: Peng Xing
>            Priority: Minor
>         Attachments: Set_config_null.png
>
>
> Open the 'Set Config' dialog, when the default key and value are null, the update button should be disabled, please refer to the attach picture.
> Otherwise it will cause NPE in Kylin server, as follows.
> {code:java}
> java.lang.NullPointerException
>         at java.util.concurrent.ConcurrentHashMap.hash(ConcurrentHashMap.java:333)
>         at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:988)
>         at org.apache.kylin.common.BackwardCompatibilityConfig.check(BackwardCompatibilityConfig.java:91)
>         at org.apache.kylin.common.KylinConfigBase.setProperty(KylinConfigBase.java:197)
>         at org.apache.kylin.rest.service.AdminService.updateConfig(AdminService.java:87)
>         at org.apache.kylin.rest.service.AdminService$$FastClassBySpringCGLIB$$e043a6d8.invoke(<generated>)
>         at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
>         at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:738)
>         at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
>         at org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:69)
>         at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
>         at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:673)
>         at org.apache.kylin.rest.service.AdminService$$EnhancerBySpringCGLIB$$f1977d91.updateConfig(<generated>)
>         at org.apache.kylin.rest.controller.AdminController.updateKylinConfig(AdminController.java:106)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)