[jira] [Updated] (HBASE-17779) disable_table_replication returns misleading message and does not turn off repliaton

["Janos Gub (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Janos Gub updated HBASE-17779:
------------------------------
    Attachment: HBASE-17779.patch

Please find initial patch.
In this one enable_table_replication and disable_table_replication always sets the replication scope for a given table, so there is no need to propagate other info to the user. Also it is a behavior change.

Should we go for another one reporting when the ReplicationState is mixed?

> disable_table_replication returns misleading message and does not turn off repliaton
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-17779
>                 URL: https://issues.apache.org/jira/browse/HBASE-17779
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Janos Gub
>            Assignee: Janos Gub
>         Attachments: HBASE-17779.patch
>
>
> Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns families is not replicated.
> Because of this if you have a table where replication is partially enabled, calling disable_table_replication will not have any effect, but will report that replication for a given table is disabled.
> Workaround is enabling table replication before disabling. 
> As a solution quoted from HBASE-17460:
> Admin#disableTableReplication() returns nothing and isTableRepEnabled() returns boolean. For master branch, we can let isTableRepEnabled() return enum (partially disabled, disabled, etc) This way, Admin#disableTableReplication() can return meaningful value to the user.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)