You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2017/02/06 17:58:06 UTC
[GitHub] incubator-madlib pull request #98: Bugfix/knn validation
GitHub user njayaram2 opened a pull request:
https://github.com/apache/incubator-madlib/pull/98
Bugfix/knn validation
knn: Fix input validation issues
- Some input validation was missing which is included now.
- there was still a bug wrt ambiguous references to column names,
which was only partly handled previously.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/njayaram2/incubator-madlib bugfix/knn-validation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 3110c40a58d2b132f6d060abbc123f5febb1ad67
Author: Nandish Jayaram <nj...@apache.org>
Date: 2017-02-03T23:30:36Z
knn: Fix input validation issues
- Some input validation was missing which is included now.
- there was still a bug wrt ambiguious references to column names,
which was only partly handled previously.
- In this version, the classification label column must be an integer,
1 and 0 for true and false. Having a boolen is not working out well
since madlib's mode function does not work with booleans. This
issue remains to be fixed, most likely will be fixed after 1.10.0
commit e96cae58d6c2b1899a8f5dea48d12458bfed354b
Author: Nandish Jayaram <nj...@apache.org>
Date: 2017-02-04T00:04:30Z
handle boolean values for classification
commit 0d9657d534f08fc2f35aa55977b0d6c28975cb0e
Author: Nandish Jayaram <nj...@apache.org>
Date: 2017-02-04T00:54:53Z
minor edits
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #98: Bugfix/knn validation
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:
https://github.com/apache/incubator-madlib/pull/98
`knn.sql` lines 404 - 407 are not necessary anymore thanks to the expanded validation function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #98: Bugfix/knn validation
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:
https://github.com/apache/incubator-madlib/pull/98
We should remove the hardcoded schema names from the tests as well. If MADlib is installed in a different schema, they might create problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #98: Bugfix/knn validation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---