You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Anakin100100 (via GitHub)" <gi...@apache.org> on 2023/03/17 09:48:00 UTC
[GitHub] [rocketmq-clients] Anakin100100 opened a new pull request, #408: try to recover on server TelemetryCommand transmission error
Anakin100100 opened a new pull request, #408:
URL: https://github.com/apache/rocketmq-clients/pull/408
I'm trying to solve the issue described by @guyinyou in #182
The new flow of execution after transmission error looks as follows:
- we encounter a server TelemetryCommand transmission error
- we set the state of recovery to true and skip to the next loop iteration
- if there is a transmission error when we are in recovery we release the observer and set the state of recovery to false
- if we manage to read the message we check if each of the servers is healthy, if not we release the observer and set the state of recovery to false
- if we managed to read the message and each server is healthy we process the message and set the state of recovery to false.
I'm going to write a unit tests for this next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #408: try to recover on server TelemetryCommand transmission error
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai merged PR #408:
URL: https://github.com/apache/rocketmq-clients/pull/408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #408: try to recover on server TelemetryCommand transmission error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #408:
URL: https://github.com/apache/rocketmq-clients/pull/408#issuecomment-1473565636
## [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#408](https://codecov.io/gh/apache/rocketmq-clients/pull/408?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (900d1e2) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/514056c2f98691d8643f9540a216e7b6854f5b81?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (514056c) will **increase** coverage by `0.00%`.
> The diff coverage is `39.58%`.
```diff
@@ Coverage Diff @@
## master #408 +/- ##
=========================================
Coverage 34.22% 34.22%
+ Complexity 663 662 -1
=========================================
Files 220 220
Lines 11458 11485 +27
Branches 279 279
=========================================
+ Hits 3921 3931 +10
- Misses 7284 7298 +14
- Partials 253 256 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| golang | `33.61% <39.58%> (+0.36%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [golang/client.go](https://codecov.io/gh/apache/rocketmq-clients/pull/408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29sYW5nL2NsaWVudC5nbw==) | `37.58% <39.58%> (+1.92%)` | :arrow_up: |
... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq-clients/pull/408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on pull request #408: try to recover on server TelemetryCommand transmission error
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on PR #408:
URL: https://github.com/apache/rocketmq-clients/pull/408#issuecomment-1475657028
Thanks @Anakin100100 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #408: try to recover on server TelemetryCommand transmission error
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on code in PR #408:
URL: https://github.com/apache/rocketmq-clients/pull/408#discussion_r1141606757
##########
golang/.gitignore:
##########
@@ -0,0 +1,2 @@
+# Go test binaries
+*.test
Review Comment:
Let's move it to the top level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] Anakin100100 commented on a diff in pull request #408: try to recover on server TelemetryCommand transmission error
Posted by "Anakin100100 (via GitHub)" <gi...@apache.org>.
Anakin100100 commented on code in PR #408:
URL: https://github.com/apache/rocketmq-clients/pull/408#discussion_r1141639853
##########
golang/.gitignore:
##########
@@ -0,0 +1,2 @@
+# Go test binaries
+*.test
Review Comment:
applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org