You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/07 18:36:10 UTC

[jira] [Commented] (MINIFI-54) ConfigSchema duplicate validation only works when processors is not null

    [ https://issues.apache.org/jira/browse/MINIFI-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366568#comment-15366568 ] 

ASF GitHub Bot commented on MINIFI-54:
--------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi-minifi/pull/30

    MINIFI-54 - Fixing duplicate validation for connections, remote proce…

    …ssing groups

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi MINIFI-54

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 5d7c016f8689faac5ab52e54c938556e3f4cbef1
Author: Bryan Rosander <br...@gmail.com>
Date:   2016-07-07T18:35:28Z

    MINIFI-54 - Fixing duplicate validation for connections, remote processing groups

----


> ConfigSchema duplicate validation only works when processors is not null
> ------------------------------------------------------------------------
>
>                 Key: MINIFI-54
>                 URL: https://issues.apache.org/jira/browse/MINIFI-54
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>            Reporter: Bryan Rosander
>
> ConfigSchema has logic to detect duplicate processor, connection, and remote processing group names.  This is to help MiNiFi ensure it can generate a valid flow.
> Unfortunately, the check is short circuited if processors are null, regardless of which duplicates it is checking for, causing for possibly missing validation errors.
> https://github.com/apache/nifi-minifi/blob/2d1e43e73b90df55abc71845160b6422d7a6f03f/minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/ConfigSchema.java#L122
> Should be changed to a null check on the names parameter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)