You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by rv...@apache.org on 2013/08/09 19:41:49 UTC
svn commit: r1512414 -
/jena/trunk/jena-arq/src/test/java/com/hp/hpl/jena/query/TestParameterizedSparqlString.java
Author: rvesse
Date: Fri Aug 9 17:41:48 2013
New Revision: 1512414
URL: http://svn.apache.org/r1512414
Log:
Test for using BNodes via <_:id> form in ParameterizedSparqlString that demonstrates they cannot be used if the variable being injected occurs in the template portion since new BNodes will be minted rather than the existing one being copied
This is indirectly related to JENA-500 and demonstrates that we likely need to restore initial bindings support for updates in some form or another
Modified:
jena/trunk/jena-arq/src/test/java/com/hp/hpl/jena/query/TestParameterizedSparqlString.java
Modified: jena/trunk/jena-arq/src/test/java/com/hp/hpl/jena/query/TestParameterizedSparqlString.java
URL: http://svn.apache.org/viewvc/jena/trunk/jena-arq/src/test/java/com/hp/hpl/jena/query/TestParameterizedSparqlString.java?rev=1512414&r1=1512413&r2=1512414&view=diff
==============================================================================
--- jena/trunk/jena-arq/src/test/java/com/hp/hpl/jena/query/TestParameterizedSparqlString.java (original)
+++ jena/trunk/jena-arq/src/test/java/com/hp/hpl/jena/query/TestParameterizedSparqlString.java Fri Aug 9 17:41:48 2013
@@ -30,14 +30,25 @@ import com.hp.hpl.jena.datatypes.TypeMap
import com.hp.hpl.jena.graph.Node;
import com.hp.hpl.jena.graph.NodeFactory;
import com.hp.hpl.jena.rdf.model.Literal;
+import com.hp.hpl.jena.rdf.model.Model;
+import com.hp.hpl.jena.rdf.model.ModelFactory;
+import com.hp.hpl.jena.rdf.model.RDFNode;
import com.hp.hpl.jena.rdf.model.Resource;
import com.hp.hpl.jena.rdf.model.ResourceFactory;
+import com.hp.hpl.jena.rdf.model.Statement;
import com.hp.hpl.jena.shared.impl.PrefixMappingImpl;
import com.hp.hpl.jena.sparql.ARQException;
import com.hp.hpl.jena.sparql.syntax.Element;
import com.hp.hpl.jena.sparql.syntax.ElementGroup;
import com.hp.hpl.jena.sparql.syntax.ElementTriplesBlock;
+import com.hp.hpl.jena.sparql.util.ResultSetUtils;
+import com.hp.hpl.jena.update.GraphStore;
+import com.hp.hpl.jena.update.GraphStoreFactory;
+import com.hp.hpl.jena.update.UpdateExecutionFactory;
+import com.hp.hpl.jena.update.UpdateProcessor;
import com.hp.hpl.jena.update.UpdateRequest;
+import com.hp.hpl.jena.vocabulary.OWL;
+import com.hp.hpl.jena.vocabulary.RDF;
import com.hp.hpl.jena.vocabulary.XSD;
/**
@@ -213,28 +224,72 @@ public class TestParameterizedSparqlStri
test(query, new String[] { "<http://example.org>", "<http://predicate>" }, new String[] { "?s", "?p" });
}
-
+
@Test
public void test_param_string_bnode_1() {
// Test Blank Node injection
String cmdText = "SELECT * WHERE { ?s ?p ?o . }";
ParameterizedSparqlString query = new ParameterizedSparqlString(cmdText);
query.setIri("s", "_:blankNodeID");
-
+
test(query, new String[] { "<_:blankNodeID>" }, new String[] { "?s" });
}
-
+
@Test
public void test_param_string_bnode_2() {
// Test Blank Node injenction
String cmdText = "INSERT { GRAPH <target> { ?node a:p ?o . } } WHERE { ?node a:p ?o . }";
ParameterizedSparqlString update = new ParameterizedSparqlString(cmdText);
update.setIri("node", "_:blankNodeID");
-
+
test(update, new String[] { "<_:blankNodeID>" }, new String[] { "?node" });
}
@Test
+ public void test_param_string_bnode_3() {
+ // Test case related to treatment of blank nodes when injecting into
+ // SPARQL updates using _: syntax
+
+ Model model = ModelFactory.createDefaultModel();
+ Resource bnode = model.createResource();
+ bnode.addProperty(RDF.type, OWL.Thing);
+ Assert.assertEquals(1, model.size());
+
+ Dataset ds = DatasetFactory.create(model);
+
+ // Use a parameterized query to check the data can be found
+ ParameterizedSparqlString pq = new ParameterizedSparqlString();
+ pq.setCommandText("SELECT * WHERE { ?s ?p ?o }");
+ pq.setIri("s", "_:" + bnode.getId());
+ Query q = pq.asQuery();
+ QueryExecution qe = QueryExecutionFactory.create(q, ds);
+ ResultSet rset = qe.execSelect();
+ Assert.assertEquals(1, ResultSetFormatter.consume(rset));
+ qe.close();
+
+ // Use a parameterized update to modify the data
+ ParameterizedSparqlString s = new ParameterizedSparqlString();
+ s.setCommandText("INSERT { ?o ?p ?s } WHERE { ?s ?p ?o }");
+ s.setIri("s", "_:" + bnode.getId());
+ UpdateRequest query = s.asUpdate();
+
+ UpdateProcessor proc = UpdateExecutionFactory.create(query, GraphStoreFactory.create(ds));
+ proc.execute();
+
+ for (Statement st : model.listStatements().toList()) {
+ System.out.println(st);
+ }
+
+ // This should be true because this was present in the intial model set
+ // up
+ Assert.assertEquals(1, model.listStatements(bnode, null, (RDFNode) null).toList().size());
+ // This should return 0 because the INSERT should result in a new blank
+ // node being created rather than the existing one being reused becaue
+ // of the semantics of blank nodes usage in templates
+ Assert.assertEquals(0, model.listStatements(null, null, bnode).toList().size());
+ }
+
+ @Test
public void test_param_string_mixed_1() {
// Test simple injection
String cmdText = "SELECT * WHERE { ?s ?p ?o . }";
@@ -1289,13 +1344,13 @@ public class TestParameterizedSparqlStri
Assert.assertEquals("SELECT * WHERE { <http://example.org> <http://predicate> \"test\", ?o . }", query.toString());
}
-
+
@Test
public void test_param_string_positional_eligible_1() {
// Test detection of eligible parameters
String cmdText = "SELECT * WHERE { ?s ?p ? . }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(cmdText);
-
+
Iterator<Integer> iter = pss.getEligiblePositionalParameters();
int count = 0;
while (iter.hasNext()) {
@@ -1304,13 +1359,13 @@ public class TestParameterizedSparqlStri
}
Assert.assertEquals(1, count);
}
-
+
@Test
public void test_param_string_positional_eligible_2() {
// Test detection of eligible parameters
String cmdText = "SELECT * WHERE { ? ? ? . }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(cmdText);
-
+
Iterator<Integer> iter = pss.getEligiblePositionalParameters();
int count = 0;
while (iter.hasNext()) {
@@ -1319,13 +1374,13 @@ public class TestParameterizedSparqlStri
}
Assert.assertEquals(3, count);
}
-
+
@Test
public void test_param_string_positional_eligible_3() {
// Test detection of eligible parameters
String cmdText = "SELECT * WHERE { ?s ?p ?; ?p1 ?, ?. }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(cmdText);
-
+
Iterator<Integer> iter = pss.getEligiblePositionalParameters();
int count = 0;
while (iter.hasNext()) {
@@ -1702,12 +1757,13 @@ public class TestParameterizedSparqlStri
pss.setLiteral(1, " . } ; DROP ALL ; INSERT DATA { <s> <p> ");
// In the positional parameter case this should fail because there
- // is only one eligible positional parameter in the string and we cannot introduce additional ones via chained injection
+ // is only one eligible positional parameter in the string and we cannot
+ // introduce additional ones via chained injection
Iterator<Integer> params = pss.getEligiblePositionalParameters();
Assert.assertTrue(params.hasNext());
params.next();
Assert.assertFalse(params.hasNext());
-
+
UpdateRequest u = pss.asUpdate();
Assert.assertEquals(1, u.getOperations().size());
}
@@ -1775,12 +1831,13 @@ public class TestParameterizedSparqlStri
pss.setLiteral(1, " . } ; DROP ALL ; INSERT DATA { <s> <p> ");
// In the positional parameter case this should fail because there
- // is only one eligible positional parameter in the string and we cannot introduce additional ones via chained injection
+ // is only one eligible positional parameter in the string and we cannot
+ // introduce additional ones via chained injection
Iterator<Integer> params = pss.getEligiblePositionalParameters();
Assert.assertTrue(params.hasNext());
params.next();
Assert.assertFalse(params.hasNext());
-
+
UpdateRequest u = pss.asUpdate();
Assert.assertEquals(1, u.getOperations().size());
}
@@ -1803,37 +1860,37 @@ public class TestParameterizedSparqlStri
String str = "SELECT * WHERE { ?s ?p ?o }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(str);
pss.setLiteral("o", "has$sign");
-
+
pss.toString();
}
-
+
@Test
public void test_param_string_bug_02() {
// Tests a bug reported with setting literals
String str = "SELECT * WHERE { ?s ?p ?o }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(str);
pss.setLiteral("o", "has$1sign");
-
+
pss.toString();
}
-
+
@Test
public void test_param_string_bug_03() {
// Tests a bug reported with setting literals
String str = "SELECT * WHERE { ?s ?p ?o }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(str);
pss.setLiteral("o", "has$5sign");
-
+
pss.toString();
}
-
+
@Test
public void test_param_string_bug_04() {
// Tests a bug reported with setting literals
String str = "SELECT * WHERE { ?s ?p ?o }";
ParameterizedSparqlString pss = new ParameterizedSparqlString(str);
pss.setLiteral("o", "has $9 sign");
-
+
pss.toString();
}
}