You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "AshinGau (via GitHub)" <gi...@apache.org> on 2023/04/03 07:52:30 UTC
[GitHub] [doris] AshinGau opened a new pull request, #18340: [fix](file_cache) turn on file cache by FE session variable
AshinGau opened a new pull request, #18340:
URL: https://github.com/apache/doris/pull/18340
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1496728198
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #18340:
URL: https://github.com/apache/doris/pull/18340#discussion_r1157036883
##########
be/src/vec/exec/format/parquet/vparquet_reader.cpp:
##########
@@ -617,12 +623,15 @@ Status ParquetReader::_process_page_index(const tparquet::RowGroup& row_group,
Slice result(col_index_buff, page_index._column_index_size);
RETURN_IF_ERROR(
_file_reader->read_at(page_index._column_index_start, result, &bytes_read, _io_ctx));
+ _column_statistics.read_bytes += bytes_read;
auto& schema_desc = _file_metadata->schema();
std::vector<RowRange> skipped_row_ranges;
uint8_t off_index_buff[page_index._offset_index_size];
Slice res(off_index_buff, page_index._offset_index_size);
RETURN_IF_ERROR(
_file_reader->read_at(page_index._offset_index_start, res, &bytes_read, _io_ctx));
+ _column_statistics.read_bytes += bytes_read;
+ _column_statistics.read_calls += 2;
Review Comment:
Add comment to explain number `2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1493861188
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1497068942
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18340:
URL: https://github.com/apache/doris/pull/18340#discussion_r1155610410
##########
be/src/vec/exec/format/parquet/parquet_thrift_util.h:
##########
@@ -35,12 +35,13 @@ namespace doris::vectorized {
constexpr uint8_t PARQUET_VERSION_NUMBER[4] = {'P', 'A', 'R', '1'};
constexpr uint32_t PARQUET_FOOTER_SIZE = 8;
-static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData** file_metadata) {
+static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData** file_metadata,
Review Comment:
warning: unused function 'parse_thrift_footer' [clang-diagnostic-unused-function]
```cpp
static Status parse_thrift_footer(io::FileReaderSPtr file, FileMetaData** file_metadata,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1495315050
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1494343243
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1497068999
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] AshinGau commented on pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #18340:
URL: https://github.com/apache/doris/pull/18340#issuecomment-1495873096
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #18340: [fix](file_cache) turn on file cache by FE session variable
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #18340:
URL: https://github.com/apache/doris/pull/18340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org