You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "s7monk (via GitHub)" <gi...@apache.org> on 2024/04/28 17:54:21 UTC
[PR] [Feature] Add logged in user cache [paimon-webui]
s7monk opened a new pull request, #198:
URL: https://github.com/apache/paimon-webui/pull/198
close: https://github.com/apache/paimon-webui/issues/197
### Purpose
Add the cache when the user logs in, and remove the cache when the user logs out, so that the currently logged-in user information can be obtained from the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add logged in user cache [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on PR #198:
URL: https://github.com/apache/paimon-webui/pull/198#issuecomment-2095125655
> @s7monk, why does this pull request add logged in user cache? IMO, it's uncessary to use cache in login and logout.
Later PR needs, for example, a flink sql gateway session needs to be created for each logged in user, so the logged in user information needs to be cached when logging in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add logged in user cache [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #198:
URL: https://github.com/apache/paimon-webui/pull/198#issuecomment-2095133241
@s7monk, I don't agree with above point. Because this cache depends on the cookie instead of the cache of the backend. Meanwhile, I don't think it's necessary for current implementation. Why do you push a pull request that later pull request needs? I did not see that the later pull request needs this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add logged in user cache [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #198:
URL: https://github.com/apache/paimon-webui/pull/198#issuecomment-2094786446
@s7monk, why does this pull request add logged in user cache? IMO, it's uncessary to use cache in login and logout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Add logged in user cache [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk closed pull request #198: [Feature] Add logged in user cache
URL: https://github.com/apache/paimon-webui/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org