You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/10/01 01:31:04 UTC

Review Request 26204: Removed the need for Master::readdSlave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26204/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

I wanted to avoid the need for both `addSlave()` and `readdSlave`.

Now, the responsibility of `addSlave()` is only to add a `Slave` struct into the master's state. Callers are responsible for telling a slave that is is registered after adding it.

This means the `Slave` constructor optionally takes executors and tasks.


Diffs
-----

  src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
  src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 

Diff: https://reviews.apache.org/r/26204/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request 26204: Removed the need for Master::readdSlave.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26204/#review55148
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/26204/#comment95531>

    Pull this down too as you did for _registerSlave() ?


- Vinod Kone


On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26204/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 11:31 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> I wanted to avoid the need for both `addSlave()` and `readdSlave`.
> 
> Now, the responsibility of `addSlave()` is only to add a `Slave` struct into the master's state. Callers are responsible for telling a slave that is is registered after adding it.
> 
> This means the `Slave` constructor optionally takes executors and tasks.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp d6380199421840aa17d4ce2725dcbcf4a11ce85f 
>   src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 
> 
> Diff: https://reviews.apache.org/r/26204/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>