[GitHub] [superset] michael-s-molina commented on pull request #16090: feat(explore): each control can define its own canDrop for dnd

[GitBox <gi...@apache.org>]

michael-s-molina commented on pull request #16090:
URL: https://github.com/apache/superset/pull/16090#issuecomment-894206937


   @kgabryje I didn't understand why we need to create an additional function for this. `canDrop` receives a `DatasourcePanelDndItem` and this object contains a `value` prop of type `DndItemValue`. Can't we just check the value inside `canDrop`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org