You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2017/02/01 17:27:30 UTC

Review Request 56180: RANGER-1325 : Usernames starting with _ not allowed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56180/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-1325 and RANGER-1343
    https://issues.apache.org/jira/browse/RANGER-1325
    https://issues.apache.org/jira/browse/RANGER-1343


Repository: ranger


Description
-------

Handles allowing User name,Group name, First name and last names to start with _ 

Also covers :: 
On admin audit page, in Action type filter EXPORT/IMPORT related actions are not available eg. EXPORT_JSON,IMPORT_JSON


Diffs
-----

  kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 22fb03c 
  security-admin/src/main/java/org/apache/ranger/common/StringUtil.java cd99588 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 77b3f95 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 2fc3b21 
  security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java ba4a8e9 
  security-admin/src/main/java/org/apache/ranger/view/VXMetricServiceCount.java 07e113e 
  security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/hbs.js b207ad1 
  security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/json2.js 02a87e8 
  security-admin/src/main/webapp/scripts/Init.js 9b22ba5 
  security-admin/src/main/webapp/scripts/models/VXGroup.js d6725a1 
  security-admin/src/main/webapp/scripts/models/VXPortalUser.js b0fe69f 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 55024d1 
  security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js 967094c 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 8b3582d 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 111d62b 
  security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 0788a4e 
  security-admin/src/main/webapp/scripts/views/users/GroupForm.js 1ff39bb 
  security-admin/src/main/webapp/scripts/views/users/UserForm.js 9422c7e 
  security-admin/src/main/webapp/styles/xa.css 5ac5255 

Diff: https://reviews.apache.org/r/56180/diff/


Testing
-------

Verified  : 

1) CRUD operations for Users / Groups 
2) Validated policy creation / updation using these users. 
3) Validated policy enforcement usign these users.
4) Validated sync of users from LDAP / AD which starts from _ 
5) Audit logs to have filters of EXPORT_JSON,IMPORT_JSON


Thanks,

Mehul Parikh


Re: Review Request 56180: RANGER-1325 : Usernames starting with _ not allowed

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56180/#review163870
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Feb. 1, 2017, 5:27 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56180/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 5:27 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1325 and RANGER-1343
>     https://issues.apache.org/jira/browse/RANGER-1325
>     https://issues.apache.org/jira/browse/RANGER-1343
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Handles allowing User name,Group name, First name and last names to start with _ 
> 
> Also covers :: 
> On admin audit page, in Action type filter EXPORT/IMPORT related actions are not available eg. EXPORT_JSON,IMPORT_JSON
> 
> 
> Diffs
> -----
> 
>   kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java 22fb03c 
>   security-admin/src/main/java/org/apache/ranger/common/StringUtil.java cd99588 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 77b3f95 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 2fc3b21 
>   security-admin/src/main/java/org/apache/ranger/view/VXMetricPolicyCount.java ba4a8e9 
>   security-admin/src/main/java/org/apache/ranger/view/VXMetricServiceCount.java 07e113e 
>   security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/hbs.js b207ad1 
>   security-admin/src/main/webapp/libs/bower/require-handlebars-plugin/js/json2.js 02a87e8 
>   security-admin/src/main/webapp/scripts/Init.js 9b22ba5 
>   security-admin/src/main/webapp/scripts/models/VXGroup.js d6725a1 
>   security-admin/src/main/webapp/scripts/models/VXPortalUser.js b0fe69f 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 55024d1 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js 967094c 
>   security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 8b3582d 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 111d62b 
>   security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 0788a4e 
>   security-admin/src/main/webapp/scripts/views/users/GroupForm.js 1ff39bb 
>   security-admin/src/main/webapp/scripts/views/users/UserForm.js 9422c7e 
>   security-admin/src/main/webapp/styles/xa.css 5ac5255 
> 
> Diff: https://reviews.apache.org/r/56180/diff/
> 
> 
> Testing
> -------
> 
> Verified  : 
> 
> 1) CRUD operations for Users / Groups 
> 2) Validated policy creation / updation using these users. 
> 3) Validated policy enforcement usign these users.
> 4) Validated sync of users from LDAP / AD which starts from _ 
> 5) Audit logs to have filters of EXPORT_JSON,IMPORT_JSON
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>