You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2008/07/16 13:58:29 UTC
Re: svn commit: r32135 - trunk/tools/dev
stylesen@tigris.org wrote:
> Author: stylesen
> Date: Wed Jul 16 01:04:25 2008
> New Revision: 32135
>
> Log:
> Obvious fix.
>
> * tools/dev/check-license.py
> (NEW_LICENSE): s/2005/2008/
That's not an obvious fix, the last change to that file was in 2005, so I don't
think we can just bump the year to 2008. Before bumping copyright years I
always check the log to see if there are any significant changes.
Regards,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32135 - trunk/tools/dev
Posted by Senthil Kumaran S <se...@collab.net>.
Julian Foad wrote:
> Blair, Senthil, are you sure you two aren't misunderstanding one
> another? It looks to me like Blair thinks this patch is updating the
> copyright notice that describes this file, but it's not. Instead, it is
> modifying the action that this script can perform so that it can be used
> this year to update copyright notices in other files. That is a correct
> fix.
>
> Senthil, the words "obvious fix" are not a sufficient explanation of a
> change. You might use those words after the description to indicate why
> you are committing a change to something outside your area, but you
> still need to include a sentence that describes the purpose of the
> change. Something like:
Thanks for the clarification Julian.
> [[[
> Update "check-license.py" so that it can generate license text
> applicable to this year.
>
> (Obvious fix.)
>
> * tools/dev/check-license.py
> (NEW_LICENSE): s/2005/2008/
> ]]]
>
> I think you just need to update the log message.
Log message updated as above.
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32135 - trunk/tools/dev
Posted by Senthil Kumaran S <se...@collab.net>.
Blair Zajac wrote:
>> Blair, Senthil, are you sure you two aren't misunderstanding one
>> another? It looks to me like Blair thinks this patch is updating the
>> copyright notice that describes this file, but it's not. Instead, it is
>> modifying the action that this script can perform so that it can be used
>> this year to update copyright notices in other files. That is a correct
>> fix.
>
> Ahh yes, thanks. This is updating the boilerplate, not the copyright in
> the file itself.
Updated the log message. Sorry for my poor log message which confused you.
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32135 - trunk/tools/dev
Posted by Blair Zajac <bl...@orcaware.com>.
Julian Foad wrote:
> On Wed, 2008-07-16 at 12:16 -0700, Blair Zajac wrote:
>> Senthil Kumaran S wrote:
>>> Blair Zajac wrote:
>>>> stylesen@tigris.org wrote:
>>>>> Author: stylesen
>>>>> Date: Wed Jul 16 01:04:25 2008
>>>>> New Revision: 32135
>>>>>
>>>>> Log:
>>>>> Obvious fix.
>>>>>
>>>>> * tools/dev/check-license.py
>>>>> (NEW_LICENSE): s/2005/2008/
>>>> That's not an obvious fix, the last change to that file was in 2005,
>>>> so I don't think we can just bump the year to 2008. Before bumping
>>>> copyright years I always check the log to see if there are any
>>>> significant changes.
>>> Should I need to revert this commit? I thought it was obvious fix, since
>>> it may help in adding new license with latest year as 2008 :(
>> It should be reverted.
>
> Blair, Senthil, are you sure you two aren't misunderstanding one
> another? It looks to me like Blair thinks this patch is updating the
> copyright notice that describes this file, but it's not. Instead, it is
> modifying the action that this script can perform so that it can be used
> this year to update copyright notices in other files. That is a correct
> fix.
Ahh yes, thanks. This is updating the boilerplate, not the copyright in the
file itself.
Regards,
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32135 - trunk/tools/dev
Posted by Julian Foad <ju...@btopenworld.com>.
On Wed, 2008-07-16 at 12:16 -0700, Blair Zajac wrote:
> Senthil Kumaran S wrote:
> > Blair Zajac wrote:
> >> stylesen@tigris.org wrote:
> >>> Author: stylesen
> >>> Date: Wed Jul 16 01:04:25 2008
> >>> New Revision: 32135
> >>>
> >>> Log:
> >>> Obvious fix.
> >>>
> >>> * tools/dev/check-license.py
> >>> (NEW_LICENSE): s/2005/2008/
> >>
> >> That's not an obvious fix, the last change to that file was in 2005,
> >> so I don't think we can just bump the year to 2008. Before bumping
> >> copyright years I always check the log to see if there are any
> >> significant changes.
> >
> > Should I need to revert this commit? I thought it was obvious fix, since
> > it may help in adding new license with latest year as 2008 :(
>
> It should be reverted.
Blair, Senthil, are you sure you two aren't misunderstanding one
another? It looks to me like Blair thinks this patch is updating the
copyright notice that describes this file, but it's not. Instead, it is
modifying the action that this script can perform so that it can be used
this year to update copyright notices in other files. That is a correct
fix.
Senthil, the words "obvious fix" are not a sufficient explanation of a
change. You might use those words after the description to indicate why
you are committing a change to something outside your area, but you
still need to include a sentence that describes the purpose of the
change. Something like:
[[[
Update "check-license.py" so that it can generate license text
applicable to this year.
(Obvious fix.)
* tools/dev/check-license.py
(NEW_LICENSE): s/2005/2008/
]]]
I think you just need to update the log message.
- Julian
> Also, for blank years, it looks like we would use
> 2005,2008 if there were significant changes in 2008.
>
> On IRC:
>
> <blairzajac> what's the policy on bumping copyright dates? we only do so for
> significant changes to the file and do we do 2005,2008 or 2005-2008 even if
> there were no changes in 2006 and 2007?
> <cmpilato> blairzajac: only for significant changes, yes. but i don't think we
> leave gaps.
> * cmpilato may not be remembering correctly, though.
> <Arfrever> blairzajac: Rather 2005,2008.
>
> Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32135 - trunk/tools/dev
Posted by Blair Zajac <bl...@orcaware.com>.
Senthil Kumaran S wrote:
> Blair Zajac wrote:
>> stylesen@tigris.org wrote:
>>> Author: stylesen
>>> Date: Wed Jul 16 01:04:25 2008
>>> New Revision: 32135
>>>
>>> Log:
>>> Obvious fix.
>>>
>>> * tools/dev/check-license.py
>>> (NEW_LICENSE): s/2005/2008/
>>
>> That's not an obvious fix, the last change to that file was in 2005,
>> so I don't think we can just bump the year to 2008. Before bumping
>> copyright years I always check the log to see if there are any
>> significant changes.
>
> Should I need to revert this commit? I thought it was obvious fix, since
> it may help in adding new license with latest year as 2008 :(
It should be reverted. Also, for blank years, it looks like we would use
2005,2008 if there were significant changes in 2008.
On IRC:
<blairzajac> what's the policy on bumping copyright dates? we only do so for
significant changes to the file and do we do 2005,2008 or 2005-2008 even if
there were no changes in 2006 and 2007?
<cmpilato> blairzajac: only for significant changes, yes. but i don't think we
leave gaps.
* cmpilato may not be remembering correctly, though.
<Arfrever> blairzajac: Rather 2005,2008.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32135 - trunk/tools/dev
Posted by Senthil Kumaran S <se...@collab.net>.
Blair Zajac wrote:
> stylesen@tigris.org wrote:
>> Author: stylesen
>> Date: Wed Jul 16 01:04:25 2008
>> New Revision: 32135
>>
>> Log:
>> Obvious fix.
>>
>> * tools/dev/check-license.py
>> (NEW_LICENSE): s/2005/2008/
>
> That's not an obvious fix, the last change to that file was in 2005, so
> I don't think we can just bump the year to 2008. Before bumping
> copyright years I always check the log to see if there are any
> significant changes.
Should I need to revert this commit? I thought it was obvious fix, since it may
help in adding new license with latest year as 2008 :(
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org