[GitHub] [flink] wangyang0918 commented on a change in pull request #12399: [FLINK-15687][runtime][test] Fix test instabilities due to concurrent access to TaskSlotTable

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #12399:
URL: https://github.com/apache/flink/pull/12399#discussion_r435186943



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskSubmissionTestEnvironment.java
##########
@@ -92,6 +93,7 @@
 	private final TestingHighAvailabilityServices haServices;
 	private final TemporaryFolder temporaryFolder;
 	private final TaskSlotTable<Task> taskSlotTable;

Review comment:
       `taskSlotTable` could be a final local variable. This will prevent the wrong use in the future for other guys who want to touch this class.

##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskSubmissionTestEnvironment.java
##########
@@ -167,6 +157,21 @@ private TaskSubmissionTestEnvironment(
 
 		taskExecutor.start();
 		taskExecutor.waitUntilStarted();
+

Review comment:
       Should we also use `threadSafeTaskSlotTable` when building `taskManagerServices` in L149?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org