You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/20 22:40:55 UTC

[GitHub] [spark] HeartSaVioR edited a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

HeartSaVioR edited a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder
URL: https://github.com/apache/spark/pull/27592#issuecomment-589386102
 
 
   Why not having umbrella issue with set a final goal (sure this should be a subtask of new umbrella issue), and port back all commits in subtasks to 3.0 only when all subtasks have been finished in time? Given we have already cut the branch for 3.0 I'm not sure why merging this to master couples with 3.0 release.
   
   EDIT: yes it's same as what @gatorsmile suggests, but explicitly defines the final goal which we agree the entire works are done.
   EDIT2: once this is merged into master, then follow-up subtasks must be marked as blockers for 3.1, as looks like we think "unknown" version info is considered as harmful. I haven't seen any usage of feature branch so that may be the only way to force it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org