[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3201: HIVE-26134: Remove Hive on Spark from the main branch

[GitBox <gi...@apache.org>]

kgyrtkirk commented on code in PR #3201:
URL: https://github.com/apache/hive/pull/3201#discussion_r848448818


##########
ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/OperatorType.java:
##########
@@ -34,7 +34,6 @@ public enum OperatorType implements org.apache.thrift.TEnum {
   ORCFILEMERGE(22),
   RCFILEMERGE(23),
   MERGEJOIN(24),
-  SPARKPRUNINGSINK(25),

Review Comment:
   this is a generated file and I don't see any changes in the thrift file - have you regenerated these files?



##########
pom.xml:
##########
@@ -1627,24 +1585,19 @@
             <log4j.debug>true</log4j.debug>
             <!-- don't diry up /tmp -->
             <java.io.tmpdir>${test.tmp.dir}</java.io.tmpdir>
-            <spark.home>${spark.home}</spark.home>
             <!-- Hadoop's minidfs class uses this -->
             <test.build.data>${test.tmp.dir}</test.build.data>
             <!-- required by QTestUtil -->
             <test.data.files>${basedir}/${hive.path.to.root}/data/files</test.data.files>
             <test.data.dir>${basedir}/${hive.path.to.root}/data/files</test.data.dir>
             <test.tmp.dir>${test.tmp.dir}</test.tmp.dir>
             <test.tmp.dir.uri>${test.tmp.dir.uri}</test.tmp.dir.uri>
-            <test.dfs.mkdir>${test.dfs.mkdir}</test.dfs.mkdir>
-            <test.output.overwrite>${test.output.overwrite}</test.output.overwrite>

Review Comment:
   seems unrelated to me - I think removing this will make the `-Dtest.output.overwrite` command line option inoperable; as it won't be passed over anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org