You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/17 07:10:02 UTC
[GitHub] [fineract-cn-mobile] PatelVatsalB21 opened a new pull request #146: Fix-278: Payroll validation added in EditPayrollBottomSheet
PatelVatsalB21 opened a new pull request #146:
URL: https://github.com/apache/fineract-cn-mobile/pull/146
Fixes [FINCN-278](https://issues.apache.org/jira/browse/FINCN-278)
Now **amount** and **account** both are checked before allocation
https://user-images.githubusercontent.com/70195106/111428515-9e071e00-871d-11eb-9c7f-579e7bdfba14.mp4
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [x] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] varsvat commented on pull request #146: Fix-278: Payroll validation added in EditPayrollBottomSheet
Posted by GitBox <gi...@apache.org>.
varsvat commented on pull request #146:
URL: https://github.com/apache/fineract-cn-mobile/pull/146#issuecomment-804838811
Only Thing I had to say is that the logic has been implemented in the manner such that while adding a new payroll, one cannot add without an account name, but he can with zero amount. So, i am concerned if adding a check on the amount field is desirable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org