[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16240: [fix] [transaction] infinite loop task that pengding ack log replay

[GitBox <gi...@apache.org>]

poorbarcode commented on code in PR #16240:
URL: https://github.com/apache/pulsar/pull/16240#discussion_r907616835


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStoreProvider.java:
##########
@@ -74,6 +74,9 @@ public void openLedgerComplete(ManagedLedger ledger, Object ctx) {
                                                 InitialPosition.Earliest, new AsyncCallbacks.OpenCursorCallback() {
                                                     @Override
                                                     public void openCursorComplete(ManagedCursor cursor, Object ctx) {
+                                                        // Why "rewind" ?
+                                                        // see: https://github.com/apache/pulsar/pull/16240
+                                                        cursor.rewind();

Review Comment:
   > Is it better to delete the cursor after recovery is complete?
   
   No, that won't solve this problem. #16247 can solve this problem, I am thinking of closing this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org