You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/15 14:55:58 UTC
[GitHub] [lucene] mikemccand opened a new pull request, #11935: #10878: add some test verbosity on failure
mikemccand opened a new pull request, #11935:
URL: https://github.com/apache/lucene/pull/11935
### Description
This change just records to an in-heap log (`PrintStream`) what the test actually did, and then prints that full log on test failure (well, when the test knowingly throws a failing exception).
I also cleaned up the wildcard imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand merged pull request #11935: #10878: add some test verbosity on failure
Posted by GitBox <gi...@apache.org>.
mikemccand merged PR #11935:
URL: https://github.com/apache/lucene/pull/11935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #11935: #10878: add some test verbosity on failure
Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #11935:
URL: https://github.com/apache/lucene/pull/11935#issuecomment-1315429989
A little more context: this test seems not to reproduce on failure, so hopefully with this verbosity, when it does fail, we can reconstruct what happened. But, it is also possible that merely adding this verbosity prevents failures (a Heisenbug). If that happens we should revert this change and try something else ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #11935: #10878: add some test verbosity on failure
Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #11935:
URL: https://github.com/apache/lucene/pull/11935#issuecomment-1315439558
Also, I think this test might be a bit borked: most of the time, after randomly throwing exceptions in a terrifying place (inside `IndexFileDeleter.decRef`), `IndexWriter` closes itself in tragic self-defense, and then the subsequent iterations of trying to do things with the writer all throw `AlreadyClosedException`.
Yet, from the failing exception, it sure looks like `ReaderPool` was somehow closed, while `IndexWriter` itself is not, on tragedy. It's like `IndexWriter` stopped its own heart but somehow its brain keeps going....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11935: #10878: add some test verbosity on failure
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11935:
URL: https://github.com/apache/lucene/pull/11935#issuecomment-1315459218
There was a somewhat similar-behaving hard-to-reproduce fail here: #11755
Not all places in IndexWriter throw `AlreadyClosedException` on tragedy. sometimes other exceptions get thrown such as `IllegalStateException`. We didn't fix the root cause in that issue but we did fix the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11935: #10878: add some test verbosity on failure
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11935:
URL: https://github.com/apache/lucene/pull/11935#issuecomment-1315461200
and... just as a warning, for that issue, if you turned on verbose, it would no longer fail anymore. So it had the heisenbug quality to it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org