You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pluto-dev@portals.apache.org by "Eric Dalquist (JIRA)" <ji...@apache.org> on 2008/03/18 21:01:24 UTC

[jira] Created: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users
-------------------------------------------------------------------------------------------------

                 Key: PLUTO-477
                 URL: https://issues.apache.org/jira/browse/PLUTO-477
             Project: Pluto
          Issue Type: Bug
          Components: portlet container
            Reporter: Eric Dalquist
             Fix For: 1.1.5


PLT.17.2 states:
    If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.

Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Created: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

Posted by Elliot Metsger <em...@jhu.edu>.

I think its worth delegating to the service impl.  That offers 
implementers the most flexibility.  we should obviously implement spec 
compliant behavior in the default service.

Nice catch,
E

Eric Dalquist wrote:
> For this issue is the check something Pluto should be doing itself? My 
> assumption here would be that if getRemoteUser() returns null the user 
> is not authenticated. If we need to delegate that check to the portal 
> via the call to the UserInfoService that works too just wondering if it 
> is even worth doing the call if there is no remote user.
> 
> -Eric
> 
> 
> 
> Eric Dalquist (JIRA) wrote:
>> PortletRequestImpl throws a NullPointerException when getting 
>> USER_INFO for unauthenticated users
>> ------------------------------------------------------------------------------------------------- 
>>
>>
>>                  Key: PLUTO-477
>>                  URL: https://issues.apache.org/jira/browse/PLUTO-477
>>              Project: Pluto
>>           Issue Type: Bug
>>           Components: portlet container
>>             Reporter: Eric Dalquist
>>              Fix For: 1.1.5
>>
>>
>> PLT.17.2 states:
>>     If the request is done in the context of an un-authenticated user, 
>> calls to the getAttribute method of the request using the USER_INFO 
>> constant must return null.
>>
>> Currently the PortletRequestImpl.createUserInfoMap() does not handle 
>> the case of UserInfoService.getUserInfo returning null for an 
>> unauthenticated user and will throw a NullPointerException in this case.
>>
>>

Re: [jira] Created: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

Posted by Eric Dalquist <er...@doit.wisc.edu>.

For this issue is the check something Pluto should be doing itself? My 
assumption here would be that if getRemoteUser() returns null the user 
is not authenticated. If we need to delegate that check to the portal 
via the call to the UserInfoService that works too just wondering if it 
is even worth doing the call if there is no remote user.

-Eric



Eric Dalquist (JIRA) wrote:
> PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users
> -------------------------------------------------------------------------------------------------
>
>                  Key: PLUTO-477
>                  URL: https://issues.apache.org/jira/browse/PLUTO-477
>              Project: Pluto
>           Issue Type: Bug
>           Components: portlet container
>             Reporter: Eric Dalquist
>              Fix For: 1.1.5
>
>
> PLT.17.2 states:
>     If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.
>
> Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.
>
>

[jira] Resolved: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

Posted by "Eric Dalquist (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PLUTO-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist resolved PLUTO-477.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.6
                   2.0.0

Allow the UserInfoService to return a null map by short-circuting in PortletRequestImpl.createUserInfoMap() and returning null immediately when the UserInfoService returns null.
Added unit test to verify fix
Cleaned up javadocs on UserInfoService to more accurately describe the implementation contract.

> PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users
> -------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-477
>                 URL: https://issues.apache.org/jira/browse/PLUTO-477
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 1.1.5
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>             Fix For: 2.0.0, 1.1.6
>
>
> PLT.17.2 states:
>     If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.
> Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

Posted by "Eric Dalquist (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PLUTO-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist reassigned PLUTO-477:
-----------------------------------

    Assignee: Eric Dalquist

> PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users
> -------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-477
>                 URL: https://issues.apache.org/jira/browse/PLUTO-477
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 1.1.5
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>
> PLT.17.2 states:
>     If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.
> Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

Posted by "Eric Dalquist (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PLUTO-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist updated PLUTO-477:
--------------------------------

        Fix Version/s:     (was: 1.1.5)
    Affects Version/s: 1.1.5

> PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users
> -------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-477
>                 URL: https://issues.apache.org/jira/browse/PLUTO-477
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 1.1.5
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>
> PLT.17.2 states:
>     If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.
> Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (PLUTO-477) PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users

Posted by "Eric Dalquist (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PLUTO-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Dalquist updated PLUTO-477:
--------------------------------

    Affects Version/s: 2.0.0

> PortletRequestImpl throws a NullPointerException when getting USER_INFO for unauthenticated users
> -------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-477
>                 URL: https://issues.apache.org/jira/browse/PLUTO-477
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container
>    Affects Versions: 2.0.0, 1.1.5
>            Reporter: Eric Dalquist
>            Assignee: Eric Dalquist
>
> PLT.17.2 states:
>     If the request is done in the context of an un-authenticated user, calls to the getAttribute method of the request using the USER_INFO constant must return null.
> Currently the PortletRequestImpl.createUserInfoMap() does not handle the case of UserInfoService.getUserInfo returning null for an unauthenticated user and will throw a NullPointerException in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.