You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/30 02:46:17 UTC

[GitHub] [doris] morrySnow commented on a diff in pull request #12169: [fix](Nereids)Sum return DoubleType when child is DecimalType by mistake

morrySnow commented on code in PR #12169:
URL: https://github.com/apache/doris/pull/12169#discussion_r957953663


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Sum.java:
##########
@@ -49,6 +50,9 @@ public DataType getDataType() {
         DataType dataType = child().getDataType();
         if (dataType instanceof LargeIntType) {
             return dataType;
+        } else if (dataType instanceof DecimalType) {

Review Comment:
   DecimalType is a SubClass of FractionalType



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org