[GitHub] [dubbo] EarthChen commented on a change in pull request #8712: feature: remove TripleRpcException

[GitBox <gi...@apache.org>]

EarthChen commented on a change in pull request #8712:
URL: https://github.com/apache/dubbo/pull/8712#discussion_r704015373



##########
File path: dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/GrpcStatus.java
##########
@@ -82,6 +83,28 @@ public static byte toDubboStatus(Code code) {
         return status;
     }
 
+    public static GrpcStatus rpcExceptionCodeToGrpc(int rpcExceptionCode) {

Review comment:
       Would it be better to replace it with enum？and put them in map and getValue




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org