[GitHub] [airflow] kaxil commented on a change in pull request #5173: AIRFLOW-4295. Make comparison of `method` case insensitive in HttpHook

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #5173: AIRFLOW-4295. Make comparison of `method` case insensitive in HttpHook
URL: https://github.com/apache/airflow/pull/5173#discussion_r281554209
 
 

 ##########
 File path: tests/hooks/test_http_hook.py
 ##########
 @@ -131,6 +132,26 @@ def test_hook_contains_header_from_extra_field(self, m):
             self.assertDictContainsSubset(json.loads(expected_conn.extra), conn.headers)
             self.assertEqual(conn.headers.get('bareer'), 'test')
 
+    @requests_mock.mock()
+    @mock.patch('requests.Request')
+    def test_hook_with_method_in_lowercase(self, m, request_mock):
 
 Review comment:
   Can we also add a simple test to assert that `get` is converted to `GET`, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services