You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/23 16:19:52 UTC
[GitHub] [beam] Capstan opened a new pull request, #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Capstan opened a new pull request, #22022:
URL: https://github.com/apache/beam/pull/22022
In one case, also switches use from an explicit Jackson serializer (`ObjectMapper`) to the `JsonFactory`'s created `JsonGenerator` for serialization, so they're symmetric.
Fixes #22018.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Capstan commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
Capstan commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1239654100
It has now been two and a half months. The github actions bot has already closed the issue due to "staleness" awaiting a review. Would you please reopen the issue and if there are further actions I need to take, please LMK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1164616806
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1463756428
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1164616811
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Capstan commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
Capstan commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1189434932
See also https://issuetracker.google.com/236761233.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1261616201
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1453481795
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1261593799
Step one would be iterate to get the tests healthy. The changes as they stand appear to be backwards-compatible so I would have no objection. A dependency swap-out is the sort of thing to discuss on the dev@beam.apache.org list, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1164616808
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1185843237
Could you clarify what the motivation is for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Capstan commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
Capstan commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1211127391
Are there additional concerns you need to see addressed? Is there anything left for me to do before this can be reviewed/approved/merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Capstan commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
Capstan commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1164618754
One side note, is that `Gson` will sometimes generate `IllegalArgumentException`s when parsing instead of just `IOException`s, so I expanded two catch blocks accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Capstan commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
Capstan commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1188673161
@robertwb The motivation is that Jackson regularly has CVEs, and Google's security team suggests using Gson for JSON parsing. The monorepo is being excised of its use of the `JacksonFactory`, and where possible, for either Google-authored code or Google-API-using code, I've been upstreaming these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22022:
URL: https://github.com/apache/beam/pull/22022#issuecomment-1261592693
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #22022: task: Migrate use of `JacksonFactory` to `GsonFactory`
URL: https://github.com/apache/beam/pull/22022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org