[GitHub] [trafficserver] shinrich commented on a change in pull request #7278: 7096: Synchronize Server Session Management and Network I/O

[GitBox <gi...@apache.org>]

shinrich commented on a change in pull request #7278:
URL: https://github.com/apache/trafficserver/pull/7278#discussion_r505750627



##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -79,9 +79,12 @@ static inline int
 read_signal_and_update(int event, UnixNetVConnection *vc)
 {
   vc->recursion++;
-  if (vc->read.vio.cont) {
+  if (vc->read.vio.cont && vc->read.vio.mutex == vc->read.vio.cont->mutex) {
     vc->read.vio.cont->handleEvent(event, &vc->read.vio);
   } else {
+    if (vc->read.vio.cont) {
+      Note("read_signal_and_update: mutexes are different? vc=%p, event=%d", vc, event);
+    }

Review comment:
       I assume this is just for debugging, right?  There should be no legitimate reason for the mutexes to mismatch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org