You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "JDarDagran (via GitHub)" <gi...@apache.org> on 2023/09/05 20:10:17 UTC

[GitHub] [airflow] JDarDagran opened a new pull request, #34122: openlineage: fix import in `get_custom_facets`

JDarDagran opened a new pull request, #34122:
URL: https://github.com/apache/airflow/pull/34122

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   This PR fixes broken import in `get_custom_facets` and adds test for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis commented on a diff in pull request #34122: openlineage: fix import in `get_custom_facets`

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34122:
URL: https://github.com/apache/airflow/pull/34122#discussion_r1316396564


##########
airflow/providers/openlineage/plugins/facets.py:
##########
@@ -33,7 +33,7 @@ class AirflowMappedTaskRunFacet(BaseFacet):
     @classmethod
     def from_task_instance(cls, task_instance):
         task = task_instance.task
-        from airflow.providers.openlineage.utils import get_operator_class
+        from airflow.providers.openlineage.utils.utils import get_operator_class

Review Comment:
   I don't think we should change that now or at all.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] JDarDagran commented on a diff in pull request #34122: openlineage: fix import in `get_custom_facets`

Posted by "JDarDagran (via GitHub)" <gi...@apache.org>.
JDarDagran commented on code in PR #34122:
URL: https://github.com/apache/airflow/pull/34122#discussion_r1316377686


##########
airflow/providers/openlineage/plugins/facets.py:
##########
@@ -33,7 +33,7 @@ class AirflowMappedTaskRunFacet(BaseFacet):
     @classmethod
     def from_task_instance(cls, task_instance):
         task = task_instance.task
-        from airflow.providers.openlineage.utils import get_operator_class
+        from airflow.providers.openlineage.utils.utils import get_operator_class

Review Comment:
   Any suggestion how to improve that? :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Taragolis commented on a diff in pull request #34122: openlineage: fix import in `get_custom_facets`

Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34122:
URL: https://github.com/apache/airflow/pull/34122#discussion_r1316367583


##########
airflow/providers/openlineage/plugins/facets.py:
##########
@@ -33,7 +33,7 @@ class AirflowMappedTaskRunFacet(BaseFacet):
     @classmethod
     def from_task_instance(cls, task_instance):
         task = task_instance.task
-        from airflow.providers.openlineage.utils import get_operator_class
+        from airflow.providers.openlineage.utils.utils import get_operator_class

Review Comment:
   utils.utils 🤣 



##########
airflow/providers/openlineage/plugins/facets.py:
##########
@@ -33,7 +33,7 @@ class AirflowMappedTaskRunFacet(BaseFacet):
     @classmethod
     def from_task_instance(cls, task_instance):
         task = task_instance.task
-        from airflow.providers.openlineage.utils import get_operator_class
+        from airflow.providers.openlineage.utils.utils import get_operator_class

Review Comment:
   utils.utils 🤣 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] mobuchowski merged pull request #34122: openlineage: fix import in `get_custom_facets`

Posted by "mobuchowski (via GitHub)" <gi...@apache.org>.
mobuchowski merged PR #34122:
URL: https://github.com/apache/airflow/pull/34122


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org