You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/05 06:11:57 UTC
[GitHub] [shardingsphere] Devamparikh commented on a diff in pull request #16595: Splitting assertMethod() method in different test cases
Devamparikh commented on code in PR #16595:
URL: https://github.com/apache/shardingsphere/pull/16595#discussion_r842391696
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-standalone-mode/shardingsphere-standalone-mode-repository/shardingsphere-standalone-mode-repository-provider/shardingsphere-standalone-mode-repository-h2/src/test/java/org/apache/shardingsphere/mode/repository/standalone/h2/H2RepositoryTest.java:
##########
@@ -34,38 +34,40 @@
@Test
public void assertMethod() {
assertThat(h2Repository.getType(), is("H2"));
- assertSetProperty();
- assertPersistAndGet();
- assertPersistAndGetChildrenKeys();
- assertDelete();
h2Repository.close();
}
-
- private void assertSetProperty() {
+
+ public void assertSetProperty() {
Review Comment:
Hey it was a mistake I have added a new PR.
Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org