[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #160: [MPLUGIN-431] Remove deprecated items from new maven-plugin-report-plugin

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #160:
URL: https://github.com/apache/maven-plugin-tools/pull/160#discussion_r1006098773


##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##########
@@ -107,7 +107,11 @@ else if ( !goalPrefix.equals( defaultGoalPrefix ) )
     static String getDefaultGoalPrefix( MavenProject project )
     {
         String defaultGoalPrefix;
-        if ( "maven-plugin".equalsIgnoreCase( project.getArtifactId() ) )
+        if ( "maven-plugin-report-plugin".equalsIgnoreCase( project.getArtifactId() ) )
+        {
+            defaultGoalPrefix = "plugin-report";

Review Comment:
   we have warning during build
   
   ```
   [WARNING] 
   
   Goal prefix is specified as: 'plugin-report'. Maven currently expects it to be 'report'.
   ```
   
   so I want to mitigate it for next release 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org