Re: svn commit: r886727 - in /ofbiz/trunk/framework/service/src/org/ofbiz/service: ModelParam.java ModelService.java

[Adrian Crum <ad...@hlmksw.com>]

I'm not familiar with SOAP, but this appears to be incorrect. The 
java.sql.Date class represents a date WITHOUT a time component.

http://java.sun.com/j2se/1.5.0/docs/api/

-Adrian

bibryam@apache.org wrote:
> Author: bibryam
> Date: Thu Dec  3 10:01:22 2009
> New Revision: 886727
> 
> URL: http://svn.apache.org/viewvc?rev=886727&view=rev
> Log:
> Fixed wsdl generation for ofbiz services.
>  - Replaced java.util.Date with java.sql.Date because the latter is used in ofbiz services.
>  - Replaced soap binding style from document to rpc, as this is the expected style in SoapEventHandler, ie the service name element, wrapping all the parameter elements in the soap body.
> 
> Modified:
>     ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelParam.java
>     ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelService.java
> 
> Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelParam.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelParam.java?rev=886727&r1=886726&r2=886727&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelParam.java (original)
> +++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelParam.java Thu Dec  3 10:01:22 2009
> @@ -236,7 +236,7 @@
>              return "dateTime";
>          } else if (ObjectType.instanceOf(com.ibm.icu.util.Calendar.class, this.type)) {
>              return "dateTime";
> -        } else if (ObjectType.instanceOf(java.util.Date.class, this.type)) {
> +        } else if (ObjectType.instanceOf(java.sql.Date.class, this.type)) {
>              return "dateTime";
>          } else if (ObjectType.instanceOf(java.lang.Long.class, this.type)) {
>              return "unsignedInt";

Re: svn commit: r886727 - in /ofbiz/trunk/framework/service/src/org/ofbiz/service: ModelParam.java ModelService.java

[Bilgin Ibryam <bi...@gmail.com>]

Adrian Crum wrote:
> I'm not familiar with SOAP, but this appears to be incorrect. The 
> java.sql.Date class represents a date WITHOUT a time component.
>  
Thanks Adrian. In r886915 I mapped the java.sql.Date to date type 
instead of dateTime

Bilgin