[jira] [Commented] (FLINK-10916) Include duplicated user-specified uid into error message

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690851#comment-16690851 ] 

ASF GitHub Bot commented on FLINK-10916:
----------------------------------------

Mododo opened a new pull request #7133: [FLINK-10916] [DataStream API] Include duplicated user-specified uid into error message
URL: https://github.com/apache/flink/pull/7133
 
 
   ## What is the purpose of the change
   
   Make it easier for user to find duplicated user-provided stream uids. 
   
   ## Brief change log
   
   Include uid in error message
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Include duplicated user-specified uid into error message
> --------------------------------------------------------
>
>                 Key: FLINK-10916
>                 URL: https://issues.apache.org/jira/browse/FLINK-10916
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Kirill Mikheev
>            Priority: Trivial
>              Labels: easyfix, newbie, pull-request-available
>
> If user provides non-unique uid for a stream, error message does not give a clue where does the error reside in client code. Including user-provided uid into error message should narrow the search area.
> In 1.6.2 we see the message that was introduced in 1.2.0:
> {noformat}
> java.lang.IllegalArgumentException: Hash collision on user-specified ID. Most likely cause is a non-unique ID. Please check that all IDs specified via uid(String) are unique. at org.apache.flink.streaming.api.graph.StreamGraphHasherV2.generateNodeHash(StreamGraphHasherV2.java:180) at org.apache.flink.streaming.api.graph.StreamGraphHasherV2.traverseStreamGraphAndGenerateHashes(StreamGraphHasherV2.java:112) at org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.createJobGraph(StreamingJobGraphGenerator.java:134) at <rest of stack>.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)