[GitHub] [cassandra-website] anthony-grasso-datastax commented on a change in pull request #17: Cassandra website is building/including the wrong versioned nodetool docs

[GitBox <gi...@apache.org>]

anthony-grasso-datastax commented on a change in pull request #17:
URL: https://github.com/apache/cassandra-website/pull/17#discussion_r481987306



##########
File path: docker-entrypoint.sh
##########
@@ -7,36 +7,44 @@ export CASSANDRA_DIR="${BUILD_DIR}/cassandra"
 
 jekyll --version
 
-# Make sure we have the latest commit of Cassandra trunk
-cd ${CASSANDRA_DIR}
+cd ${CASSANDRA_SITE_DIR}/src
+
+# Now make the docs for the latest version
+pushd ${CASSANDRA_DIR}
+git clean -xdff
 git checkout trunk
 git pull --rebase --prune
+popd
+make .build-doc .latest-doc-link
 
-# Now make the docs for the latest version
-cd ${CASSANDRA_SITE_DIR}/src
-make add-latest-doc
 
+# Uncomment for building docs for each of the released versions on the 3.11 branch
+#
+#versions="cassandra-3.11.5 cassandra-3.11.6 cassandra-3.11.7 cassandra-3.11.8"
+#
+#for v in $versions ; do
+#  pushd ${CASSANDRA_DIR}
+#  git clean -xdff
+#  git checkout $v
+#  popd
+#  make .build-doc
+#done

Review comment:
       I would make this an option we pass to the entrypoint to enable this. By default it is disabled unless a flag is supplied.

##########
File path: docker-entrypoint.sh
##########
@@ -7,36 +7,44 @@ export CASSANDRA_DIR="${BUILD_DIR}/cassandra"
 
 jekyll --version
 
-# Make sure we have the latest commit of Cassandra trunk
-cd ${CASSANDRA_DIR}
+cd ${CASSANDRA_SITE_DIR}/src
+
+# Now make the docs for the latest version
+pushd ${CASSANDRA_DIR}
+git clean -xdff
 git checkout trunk
 git pull --rebase --prune
+popd
+make .build-doc .latest-doc-link
 
-# Now make the docs for the latest version
-cd ${CASSANDRA_SITE_DIR}/src
-make add-latest-doc
 
+# Uncomment for building docs for each of the released versions on the 3.11 branch
+#
+#versions="cassandra-3.11.5 cassandra-3.11.6 cassandra-3.11.7 cassandra-3.11.8"

Review comment:
       Please add a comment saying that doc generations only work for version 3.11.5 and above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org