You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Rohini Palaniswamy (Jira)" <ji...@apache.org> on 2020/02/21 20:04:00 UTC

[jira] [Comment Edited] (TEZ-2119) Counter for launched containers

    [ https://issues.apache.org/jira/browse/TEZ-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042142#comment-17042142 ] 

Rohini Palaniswamy edited comment on TEZ-2119 at 2/21/20 8:03 PM:
------------------------------------------------------------------

Haven't reviewed the code for correctness of the counter increments. But based on Hitesh's comment, below ones make sense
INITIAL_HELD_CONTAINERS, //both allocated and launched containers before dag start
TOTAL_ALLOCATED_CONTAINERS,
TOTAL_LAUNCHED_CONTAINERS,
TOTAL_RELEASED_CONTAINERS,
TOTAL_REUSED_CONTAINERS

I am not sure what TOTAL_USED_CONTAINERS means as earlier comment by Jeff meant it to be same as INITIAL_HELD_CONTAINERS. Looking at code, it seems to be about same as TOTAL_LAUNCHED_TASKS which we can skip in my opinion.


was (Author: rohini):
Haven't reviewed the code for correctness of the counter increments, but based on Hitesh's comment, below ones make sense
INITIAL_HELD_CONTAINERS, //both allocated and launched containers before dag start
TOTAL_ALLOCATED_CONTAINERS,
TOTAL_LAUNCHED_CONTAINERS,
TOTAL_RELEASED_CONTAINERS,
TOTAL_REUSED_CONTAINERS

I am not sure what TOTAL_USED_CONTAINERS means as earlier comment by Jeff meant it to be same as INITIAL_HELD_CONTAINERS. Looking at code, it seems to be about same as TOTAL_LAUNCHED_TASKS which we can skip in my opinion.

> Counter for launched containers
> -------------------------------
>
>                 Key: TEZ-2119
>                 URL: https://issues.apache.org/jira/browse/TEZ-2119
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Rohini Palaniswamy
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-2119.01.patch
>
>
> org.apache.tez.common.counters.DAGCounter
>                 NUM_SUCCEEDED_TASKS=32976
>                 TOTAL_LAUNCHED_TASKS=32976
>                 OTHER_LOCAL_TASKS=2
>                 DATA_LOCAL_TASKS=9147
>                 RACK_LOCAL_TASKS=23761
> It would be very nice to have TOTAL_LAUNCHED_CONTAINERS counter added to this. The difference between TOTAL_LAUNCHED_CONTAINERS and TOTAL_LAUNCHED_TASKS should make it easy to see how much container reuse is happening. It is very hard to find out now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)