[PR] Use set for llm_completed and remove dead pending branch in TUI [airflow]

["andreahlert (via GitHub)" <gi...@apache.org>]

andreahlert opened a new pull request, #64585:
URL: https://github.com/apache/airflow/pull/64585

   ## Summary
   
   ### Why
   llm_completed is checked on every poll cycle to filter out already-collected futures, and as a list that check is O(n) per future which gets noticeable with larger batches.
   
   `llm_completed` is used to track which LLM futures have already been collected. It was a list, so the `f not in llm_completed` check in `_collect_llm_results` was O(n) on every poll cycle,. With many PRs this adds up. Switched to a set for O(1) lookup. No behavior change since the container is never iterated, indexed, or ordered.
   
   Also removed a duplicate `elif entry.llm_status == "pending"` branch in the TUI PR table builder that was shadowed by an earlier branch in the same chain and could never execute.
   
   ## Test plan
   
   - All existing tests pass (75 TUI + 39 LLM = 114 tests)
   - `breeze pr auto-triage --tui` works as before
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [ ] No
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use set for llm_completed and remove dead pending branch in TUI [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #64585:
URL: https://github.com/apache/airflow/pull/64585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Use set for llm_completed and remove dead pending branch in TUI [airflow]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #64585:
URL: https://github.com/apache/airflow/pull/64585#issuecomment-4171142036

   ### Backport failed to create: v3-2-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/23858208421'> Run details </a>
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
       <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>❌</td>
           <td>v3-2-test</td>
           <td><a href="https://github.com/apache/airflow/commit/6bd6fdfb037fb0c83939d55d0f3cd81d7ebc9000"><img src='https://img.shields.io/badge/Commit-6bd6fdf-red' alt='Commit Link'></a></td>
       </tr>
   </table>
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker 6bd6fdf v3-2-test
   ```
   
   This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process by running:
   
   ```bash
   cherry_picker --continue
   ```
   
   If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org