You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/20 10:13:49 UTC

[GitHub] [flink] zentol commented on a diff in pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull

zentol commented on code in PR #20314:
URL: https://github.com/apache/flink/pull/20314#discussion_r925429140


##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironment.java:
##########
@@ -57,7 +57,7 @@
 import org.apache.flink.util.UserCodeClassLoader;
 import org.apache.flink.util.concurrent.Executors;
 
-import com.sun.istack.NotNull;
+import org.jetbrains.annotations.NotNull;

Review Comment:
   Let's just remove this usage. Such annotation shouldn't be used at all, because for new code we go in with the assumption that nothing is nullable unless it is annotated accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org