You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/05 01:53:56 UTC

[GitHub] [apisix-dashboard] imjoey opened a new pull request #1203: fix: Set create_time/update_time as omitempty

imjoey opened a new pull request #1203:
URL: https://github.com/apache/apisix-dashboard/pull/1203


   Signed-off-by: imjoey <ma...@gmail.com>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   Fixes #1176 .
   
   ___
   ### Bugfix
   - Description
   
   The empty values of `create_time` and `update_time` should not be returned from server_info interface provided by manager-api . Please see #1176 for details.
   
   **Note**:
   
   This PR was previously proposed in #1192 , I could not be able to reopen that PR due to my fault operation after closed it. @nic-chen @liuxiran left their opinions, pls see https://github.com/apache/apisix-dashboard/pull/1192/files#issuecomment-753858234 and https://github.com/apache/apisix-dashboard/pull/1192/files#issuecomment-753972035 . 
   
   Firstly I agreed with @nic-chen and @liuxiran for their perfect solutions for all entities. While after some digs, the perfect solution would bring significant changes to refactor the `BaseInfo` in entities. IMHO, in order to fix #1176 , this PR could also bring an elegant, effective and maintainable way with relatively less cost.
   
   @nic-chen @liuxiran , please allow me to reopen this PR to ask for more opinions 😄 , in order to have #1176 fixed in v2.3 release.
   
   @membphis @tokers @ShiningRush  @juzhiyuan could you pls leave your comments at your convenience. Much appreciated.
   
   - How to fix?
   
   This PR is going to set `create_time` and `update_time` as `omitempty` to disable JSON serialization when returning back to frontend. In addition, adding the relevant test case for changes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1203: fix: Set create_time/update_time as omitempty

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1203:
URL: https://github.com/apache/apisix-dashboard/pull/1203#issuecomment-754334548


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=h1) Report
   > Merging [#1203](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=desc) (24952c3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45e90ec8e13a1c9659645034f1fd50f0552b93e3?el=desc) (45e90ec) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1203/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1203   +/-   ##
   =======================================
     Coverage   42.38%   42.38%           
   =======================================
     Files          31       31           
     Lines        1930     1930           
   =======================================
     Hits          818      818           
     Misses       1001     1001           
     Partials      111      111           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1203/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=footer). Last update [45e90ec...24952c3](https://codecov.io/gh/apache/apisix-dashboard/pull/1203?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1203: fix: Set create_time/update_time as omitempty

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1203:
URL: https://github.com/apache/apisix-dashboard/pull/1203


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org