Re: [PR] [incubator-kie-issues#1478] Register DRG callbacks to assigned models from DMNCompilerImpl [incubator-kie-drools]

["samuel-beniamin (via GitHub)" <gi...@apache.org>]

samuel-beniamin commented on PR #6105:
URL: https://github.com/apache/incubator-kie-drools/pull/6105#issuecomment-2455029181

   > Hi @samuel-beniamin thanks for the PR. I tried to understand better the overall context, and I'm sharing my thoughts: please correct me if/where I'm wrong: I may misread something.
   > 
   > 1. by itself, I think the fix could be right
   > 2. but those AfterProcessDrgElements / addCallback /  addCallbackForModel are used/needed only by the signavio module
   > 3. but being defined/ implemented in the "core"  DMNCompilerImpl, those somehow "pollute" it with something that, IMO, has no reason to be there
   > 
   > So, I was thinking to
   > 
   > 1. change `DMNCompilerImpl.processDrgElements` from private to protected, to be overridable
   > 2. get rid of all signavio-specific stuff from it (double check also the tests)
   > 3. create a signavio-specific subclass of `DMNCompilerImpl` that add the behavior required by signavio
   > 4. put your modifications in that subclass
   > 
   > The idea would be to have `DMNCompilerImpl` dealing only with "core" responsibilities, and move implementation-specific ones (e.g. signavio) to dedicated subclasses
   > 
   > Wdyt ? Does this make sense ? Do you think you could do that ?
   > 
   > @baldimir @yesamer
   
   Hello @gitgabrio,
   
   Thank you for taking the time to review the code and for your suggestions.
   
   I think your suggestions make sense, I believe I understood what need to be done, and I will be happy to make these changes in this PR as well, if that is okay.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org