You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/09/17 10:37:37 UTC
Re: Review Request 68711: Added `task ls` command to new CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/
-----------------------------------------------------------
(Updated Sept. 17, 2018, 12:37 p.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Rebased on refactoring.
Summary (updated)
-----------------
Added `task ls` command to new CLI.
Bugs: MESOS-8795
https://issues.apache.org/jira/browse/MESOS-8795
Repository: mesos
Description (updated)
-------
Added `task ls` command to new CLI.
Diffs (updated)
-----
src/python/cli_new/lib/cli/agents.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9
src/python/cli_new/lib/cli/tasks.py PRE-CREATION
src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0
Diff: https://reviews.apache.org/r/68711/diff/3/
Changes: https://reviews.apache.org/r/68711/diff/2-3/
Testing
-------
Tested manually and:
```
(mesos-cli) ? cli_new (DCOS_OSS-4083) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 5 tests in 9.656s
OK
```
Thanks,
Armand Grillet
Re: Review Request 68711: Added `task ls` command to new CLI.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/#review208720
-----------------------------------------------------------
src/python/cli_new/lib/cli/tasks.py
Lines 28 (patched)
<https://reviews.apache.org/r/68711/#comment292875>
now that we're using python3, why not start adding type annotations? e.g.
```
def get_task(tasks: dict, task_id: str):
...
```
this will help greatly with avoiding unnecessary bugs
- Eric Chung
On Sept. 17, 2018, 10:37 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68711/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task ls` command to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/agents.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9
> src/python/cli_new/lib/cli/tasks.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0
>
>
> Diff: https://reviews.apache.org/r/68711/diff/6/
>
>
> Testing
> -------
>
> Tested manually and:
> ```
> (mesos-cli) bash-3.2$ mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 9.656s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68711: Added `task ls` command to new CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/#review208680
-----------------------------------------------------------
PASS: Mesos patch 68711 was successfully built and tested.
Reviews applied: `['68734', '68711']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2345/mesos-review-68711
- Mesos Reviewbot Windows
On Sept. 17, 2018, 10:37 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68711/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task ls` command to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/agents.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9
> src/python/cli_new/lib/cli/tasks.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0
>
>
> Diff: https://reviews.apache.org/r/68711/diff/3/
>
>
> Testing
> -------
>
> Tested manually and:
> ```
> (mesos-cli) ? cli_new (DCOS_OSS-4083) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 9.656s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68711: Added `task ls` command to new CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/#review208681
-----------------------------------------------------------
PASS: Mesos patch 68711 was successfully built and tested.
Reviews applied: `['68734', '68711']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2346/mesos-review-68711
- Mesos Reviewbot Windows
On Sept. 17, 2018, 10:37 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68711/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task ls` command to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/agents.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9
> src/python/cli_new/lib/cli/tasks.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0
>
>
> Diff: https://reviews.apache.org/r/68711/diff/6/
>
>
> Testing
> -------
>
> Tested manually and:
> ```
> (mesos-cli) bash-3.2$ mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 9.656s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68711: Added `task ls` command to new CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68711/
-----------------------------------------------------------
(Updated Oct. 8, 2018, 3:09 p.m.)
Review request for mesos, Eric Chung and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-8795
https://issues.apache.org/jira/browse/MESOS-8795
Repository: mesos
Description
-------
Added `task ls` command to new CLI.
Diffs (updated)
-----
src/python/cli_new/lib/cli/mesos.py 068d694fb6407565003c9b65a71c2b1f7fb70c77
src/python/cli_new/lib/cli/plugins/task/main.py a47a8c53ee2d8d468ea0f9947ea3f65d81fc9251
src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0
Diff: https://reviews.apache.org/r/68711/diff/7/
Changes: https://reviews.apache.org/r/68711/diff/6-7/
Testing
-------
Tested manually and:
```
(mesos-cli) bash-3.2$ mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_ls (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 5 tests in 9.656s
OK
```
Thanks,
Armand Grillet