You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "melihsozdinler (via GitHub)" <gi...@apache.org> on 2023/08/17 20:20:09 UTC

[GitHub] [spark] melihsozdinler commented on a diff in pull request #42296: [SPARK-44635][CORE] Handle shuffle fetch failures in decommissions

melihsozdinler commented on code in PR #42296:
URL: https://github.com/apache/spark/pull/42296#discussion_r1297700192


##########
core/src/main/scala/org/apache/spark/TestUtils.scala:
##########
@@ -491,6 +491,27 @@ private[spark] object TestUtils {
       EnumSet.of(OWNER_READ, OWNER_EXECUTE, OWNER_WRITE))
     file.getPath
   }
+
+  def withConf[T](confPairs: (String, String)*)(f: => T): T = {

Review Comment:
   It is nice to add some comments for the usage of this function, we see that some other public functions had before in this file. Better to follow the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org