You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/29 02:54:19 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #15458: [chore](thirdparty) Support cleaning extracted data before building them
adonis0147 opened a new pull request, #15458:
URL: https://github.com/apache/doris/pull/15458
# Proposed changes
~~Issue Number: close #xxx~~
## Problem summary
Currently, we may fail to build the third-party libraries if we keep the outdated extracted data.
Considering the following scenario, Bob added patches to some libraries and Alice updates the codebase and builds the third-party libraries. If Alice kept the outdated extracted data, she should fail to build the third-party libraries because the patches are not applied due to the outdated `patched_mark`s.
This PR introduces a way to clean the outdated data before building the third-party libraries.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15458:
URL: https://github.com/apache/doris/pull/15458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15458:
URL: https://github.com/apache/doris/pull/15458#issuecomment-1367137798
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15458:
URL: https://github.com/apache/doris/pull/15458#issuecomment-1367060533
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.47 seconds
load time: 680 seconds
storage size: 17123055195 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221229041209_clickbench_pr_70638.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15458: [chore](thirdparty) Support cleaning extracted data before building them
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15458:
URL: https://github.com/apache/doris/pull/15458#issuecomment-1367137828
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org